[Fawkes Git] branch/tneumann/angle_distance_fix: utils: fix calculation of angle_distance in math/angle.h

Tobias Neumann tobias.neumann at alumni.fh-aachen.de
Tue Feb 9 22:11:15 CET 2016


Changes have been pushed for the project "Fawkes Robotics Software Framework".

Gitweb: http://git.fawkesrobotics.org/fawkes.git
Trac:   http://trac.fawkesrobotics.org

The branch, tneumann/angle_distance_fix has been updated
  discards  3e6dc9b4ae238afffd4ba42684802b4534a8e97a (commit)
        to  27237fec6689b242dfae0b280123845f7f48170a (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (3e6dc9b4ae238afffd4ba42684802b4534a8e97a)
            \
             N -- N -- N (27237fec6689b242dfae0b280123845f7f48170a)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

http://git.fawkesrobotics.org/fawkes.git/tneumann/angle_distance_fix

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- *Log* ---------------------------------------------------------------
commit 27237fec6689b242dfae0b280123845f7f48170a
Author:     Tobias Neumann <t.neumann at fh-aachen.de>
AuthorDate: Tue Feb 9 22:07:45 2016 +0100
Commit:     Tobias Neumann <t.neumann at fh-aachen.de>
CommitDate: Tue Feb 9 22:07:45 2016 +0100

    utils: fix calculation of angle_distance in math/angle.h
    
    the calculation returned a signed value which should be implemented in a
    function called like signed_angle_distance(angle_to, angle_from)

http://git.fawkesrobotics.org/fawkes.git/commit/27237fe
http://trac.fawkesrobotics.org/changeset/27237fe

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -


- *Summary* -----------------------------------------------------------
 src/libs/utils/math/angle.h |   14 +-------------
 1 files changed, 1 insertions(+), 13 deletions(-)


- *Diffs* -------------------------------------------------------------

- *commit* 27237fec6689b242dfae0b280123845f7f48170a - - - - - - - - - -
Author:  Tobias Neumann <t.neumann at fh-aachen.de>
Date:    Tue Feb 9 22:07:45 2016 +0100
Subject: utils: fix calculation of angle_distance in math/angle.h

 src/libs/utils/math/angle.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/utils/math/angle.h b/src/libs/utils/math/angle.h
index b1420ab..3d2c224 100644
--- a/src/libs/utils/math/angle.h
+++ b/src/libs/utils/math/angle.h
@@ -130,7 +130,7 @@ inline float
 angle_distance(float angle_rad1,
 	       float angle_rad2)
 {
-  return normalize_mirror_rad(angle_rad2 - angle_rad1);
+  return fabs( normalize_mirror_rad(angle_rad2 - angle_rad1) );
 }
 
 




-- 
Fawkes Robotics Framework                 http://www.fawkesrobotics.org


More information about the fawkes-commits mailing list